feat(frontend): slugify error-list paths

getindiekit · Aug 8, 2023 · daec422 · daec422
1 parent 01c4542
commit daec422
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/packages/frontend/lib/globals/error-list.js b/packages/frontend/lib/globals/error-list.js
@@ -1,5 +1,4 @@
-const _camelToSnakeCase = (string) =>
-  string.replaceAll(/[A-Z]/g, (letter) => `-${letter.toLowerCase()}`);
+import { slugify } from "@indiekit/util";
 
 /**
  * Transform errors provided by express-validator into array that can be
@@ -14,7 +13,7 @@ export const errorList = (errorMap) => {
   for (const fieldError of fieldsWithErrors) {
     errorList.push({
       text: fieldError[1].msg,
-      href: `#${_camelToSnakeCase(fieldError[1].path)}`,
+      href: `#${slugify(fieldError[1].path, { decamelize: true })}`,
     });
   }
 

diff --git a/packages/frontend/tests/unit/globals/error-list.js b/packages/frontend/tests/unit/globals/error-list.js
@@ -6,11 +6,11 @@ test("Transforms errors provided by express-validator", (t) => {
     me: {
       value: "foo",
       msg: "Enter a valid URL",
-      path: "customConfigUrl",
+      path: "fooBar[0].url",
       location: "body",
     },
   });
 
-  t.is(result[0].href, "#custom-config-url");
+  t.is(result[0].href, "#foo-bar-0-url");
   t.is(result[0].text, "Enter a valid URL");
 });