Fix $file::changeTemplate()
#6739
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distantnative
force-pushed
the
fix/file-change-template
branch
from
2757fe4
to
11fbc6e
Compare
distantnative
commented
Oct 15, 2024
| @@ -367,6 +367,9 @@ public function testChangeTemplateMultilang() | |||
| $modified = $file->changeTemplate('b'); | |||
|
|
|||
| $this->assertSame('b', $modified->template()); | |||
| $this->assertSame('b', $modified->content('default')->get('template')->value()); | |||
| $this->assertSame('b', $modified->content('en')->get('template')->value()); | |||
| $this->assertNull($modified->content('de')->get('template')->value()); | |||
There was a problem hiding this comment.
@bastianallgeier maybe you have an idea with your content class/caching knowledge why this still has a when a non-default language should never have a template field for a file?
There was a problem hiding this comment.
At this stage, I believe that we merge it with the default language content.
There was a problem hiding this comment.
Problem is that the default language has been updated to b, but the secondary language still seems to be stuck with a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
Changelog
Fixes
Ready?
For review team