Color field: warning for deprecated notation #6913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
distantnative
force-pushed
the
v5/refactor/todo-color-options
branch
from
4121169 to
e9529e3
Compare
|
@bastianallgeier now I remember why I removed those tests in the first place XD they fail due to the deprecation warning |
|
Didn't we have something to disable this in tests? I can't remember correctly anymore. Otherwise, we should probably really remove them. |
|
Let's move it to beta.3 |
|
@bastianallgeier the opposite: https://github.com/getkirby/kirby/blob/main/src/Cms/Helpers.php#L63 - we explicitly avoid swallowing the message when running in test mode. I have removed the test again. |
distantnative
force-pushed
the
v5/refactor/todo-color-options
branch
from
e9529e3 to
993cf32
Compare
bastianallgeier
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Deprecated
text => valuenotation for options has been deprecated and will be removed in Kirby 6. Please rewrite your options asvalue => text.Ready?
For review team