-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drawer / Fields block: collapse tabs in header to dropdown in narrow columns #6914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 17, 2025
@afbora is People in your example another tab or the title? |
That's a title. I've used the sample blueprint in the #6864 |
Wondering why it doesn't wrap as this PR adds the CSS for wrapping. Cause it would still be too wide even on its own row? |
distantnative
force-pushed
the
fix/6864-fields-block-header-wrap
branch
from
January 25, 2025 12:24
4f80c2e
to
803c8a2
Compare
@afbora new attempt |
distantnative
changed the title
Fields block: wrap tabs in header
Drawer / Fields block: collapse tabs in header to dropdown in narrow columns
Jan 25, 2025
@bastianallgeier Is it intended that the drawer title disappears? |
@distantnative that already happened before my changes. |
distantnative
force-pushed
the
fix/6864-fields-block-header-wrap
branch
from
January 27, 2025 13:33
acb60ec
to
c10ab5a
Compare
:D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
This will not solve the issue that tabs will still overlap when the tabs component alone is wider than the column.
Changelog
Fixes
Block field: Tabs overlapping block title #6864
Blocks with
preview: fields
: Block name and tabs do not wrap #6634Ready?
For review team