Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawer / Fields block: collapse tabs in header to dropdown in narrow columns #6914

Merged
merged 6 commits into from
Jan 27, 2025

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jan 17, 2025

Description

Additional context

This will not solve the issue that tabs will still overlap when the tabs component alone is wider than the column.

Changelog

Fixes

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@afbora
Copy link
Member

afbora commented Jan 20, 2025

1024x768px

v5-develop test_panel_pages_test

I know this pr doesn't fix the issue completely Bu what about switching to dropdown automaticly for these cases?

@distantnative
Copy link
Member Author

@afbora is People in your example another tab or the title?

@afbora
Copy link
Member

afbora commented Jan 20, 2025

That's a title. I've used the sample blueprint in the #6864

@distantnative
Copy link
Member Author

Wondering why it doesn't wrap as this PR adds the CSS for wrapping. Cause it would still be too wide even on its own row?

@distantnative distantnative modified the milestones: 4.6.0, 4.7.0 Jan 22, 2025
@distantnative distantnative force-pushed the fix/6864-fields-block-header-wrap branch from 4f80c2e to 803c8a2 Compare January 25, 2025 12:24
@distantnative distantnative changed the base branch from develop-minor to v5/develop January 25, 2025 12:24
@distantnative distantnative modified the milestones: 4.7.0, 5.0.0-beta.3 Jan 25, 2025
@distantnative
Copy link
Member Author

@afbora new attempt

@distantnative distantnative changed the title Fields block: wrap tabs in header Drawer / Fields block: collapse tabs in header to dropdown in narrow columns Jan 25, 2025
@bastianallgeier
Copy link
Member

bastianallgeier commented Jan 27, 2025

I've added some additional improvements that might work. It's not super beautiful when there's a name, label and lots of tabs, but it all stays readable at least …

Screenshot 2025-01-27 at 13 21 07

Screenshot 2025-01-27 at 13 19 36

Screenshot 2025-01-27 at 13 20 43

it looks a lot better when the name and label shrink and get a text overflow, but of course we loose readability that way.

@distantnative
Copy link
Member Author

@bastianallgeier Is it intended that the drawer title disappears?

@bastianallgeier
Copy link
Member

@distantnative that already happened before my changes.

@distantnative distantnative force-pushed the fix/6864-fields-block-header-wrap branch from acb60ec to c10ab5a Compare January 27, 2025 13:33
@distantnative
Copy link
Member Author

:D

@distantnative distantnative merged commit 254a119 into v5/develop Jan 27, 2025
4 checks passed
@distantnative distantnative deleted the fix/6864-fields-block-header-wrap branch January 27, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Block field: Tabs overlapping block title Blocks with preview: fields: Block name and tabs do not wrap
3 participants