Support shared site.contentType.php controller
#6950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distantnative
added
the
needs: discussion 🗣
distantnative
commented
Jan 24, 2025
| if ($controller = $this->controllerLookup('site')) { | ||
| $data = (array)$controller->call($this, $arguments); | ||
| $site = $this->controllerLookup('site', $contentType); | ||
| $site ??= $this->controllerLookup('site'); |
There was a problem hiding this comment.
Discuss: Is it ok that we use either or? Or should both site controllers be used, if available?
| 'template' => 'another' | ||
| ]); | ||
|
|
||
| ob_start(); | ||
| $app->controller('another.json', [], 'json'); |
There was a problem hiding this comment.
Question: Was it ever right to have this test calling with another.json as name and json as contentType instead of another and json?
| @@ -1,3 +1,5 @@ | |||
| <?php | |||
|
|
|||
| echo json_encode(['foo' => 'bar']); | |||
There was a problem hiding this comment.
Question: Why would the controller echo the JSON? Isn't that the job of the template in a content representation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
site.json.phpsite.phpor the more specific representation site controller get merged into any other controller, but never bothReasoning
Allows to globally provide data to all controllers/templates that only a specific content type needs.
Additional context
blog.rsswith noblog.rss.phpcontroller would take the regularblog.phpcontroller merged with a potentially existingsite.rss.phpcontroller. Seems a bit weird, but probably also not harmful. Not sure how I feel about it.Changelog
Enhancement
site.rss.phpReady?
For review team