Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect html representation URLs #6953

Open
wants to merge 1 commit into
base: develop-minor
Choose a base branch
from

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jan 25, 2025

Description

Summary of changes

  • Requests for a page's html representation get redirected to the normal page URL without extension

Reasoning

Avoiding duplicate content, e.g. at https://getkirby.com/docs as well as https://getkirby.com/docs.html.

I have explained in #6509 (comment) why I think making Kirby stricter here and just delivering content if a docs.html.php template exists would be the wrong direction IMO, considering that within the Kirby system the one without any extension is directly tied to html as type. Having the option to have a docs.php alongside docs.html.php would be a contradiction.

Changelog

Fixes

  • Requests for a page's html representation get redirected to the normal page URL without extension

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added this to the 4.7.0 milestone Jan 25, 2025
@distantnative distantnative self-assigned this Jan 25, 2025
@distantnative distantnative linked an issue Jan 25, 2025 that may be closed by this pull request
@distantnative distantnative marked this pull request as ready for review January 25, 2025 12:30
@distantnative distantnative requested a review from a team January 25, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate content when appending .html to page URLs
1 participant