-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Panel
package
#6955
Draft
distantnative
wants to merge
18
commits into
v5/develop
Choose a base branch
from
v5/refactor/panel-php
base: v5/develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Refactor Panel
package
#6955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distantnative
force-pushed
the
v5/refactor/panel-php
branch
from
January 25, 2025 19:51
77a3bc2
to
bdf29f6
Compare
distantnative
force-pushed
the
v5/refactor/panel-php
branch
from
January 25, 2025 19:52
bdf29f6
to
2ff6997
Compare
distantnative
force-pushed
the
v5/refactor/panel-php
branch
from
January 25, 2025 20:29
59b9414
to
271fa6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Certainly a PR with a lower priority
Summary of changes
Panel\Ui\Dialogs\
Panel\Panel
andPanel\View
classesPanel\Areas
for the logic around gathering and resolving area definitionsPanel\Fiber
handles all of the Fiber data wrangling incl. globalsPanel\Access
took over the firewall part (mainly just to have that in one place that's not makingPanel\Panel
larger)Panel\Router
takes care of the routing and general response for the Panel$
key prefixes$kirby->panel()
that returns thePanel\Panel
objectReasoning
The labyrinth of static method calls was just so hard to parse and some classes (
Panel
andView
) were getting way to bigI also wanted to get a way to access much of this via the
$kirby
class. So I needed to start a non-static chain of objects.Additional context
Are there ways to make this easier to review?
Changelog
Fixes
Breaking changes
$
. This also affects Panel plugins reloading the Panel by defining only specific keys to be reloaded.Panel
package classes are now non-static. If you are using them in your code directly, you'll need to update your call signatures.Ready?
For review team