Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle state updates in the ModelWithContent::save method #7061

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Handle state updates in the ModelWithContent::save method #7061

merged 1 commit into from
Mar 12, 2025
+6 −40

Conversation

bastianallgeier
Copy link
Member

@bastianallgeier bastianallgeier commented Mar 12, 2025 •
edited
Loading

Summary of changes

  • File::save() and Page::save() have been removed and the model state update has been moved to the ModelWithContent::save() method

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@bastianallgeier bastianallgeier merged commit dd5276c into v5/develop Mar 12, 2025
12 checks passed
@bastianallgeier bastianallgeier deleted the v5/simplify-save-action branch March 12, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@distantnative distantnative distantnative approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastianallgeier @distantnative