Skip to content

Commit

Permalink
misc(analytics): Rename outstanding invoices to finalized invoices
Browse files Browse the repository at this point in the history
  • Loading branch information
ivannovosad committed Nov 23, 2023
1 parent 9bd9b5f commit f8e94b9
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 18 deletions.
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
lago-ruby-client (0.51.0.pre.beta)
lago-ruby-client (0.52.1.pre.beta)
jwt
openssl

Expand Down
2 changes: 1 addition & 1 deletion lib/lago-ruby-client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@
require 'lago/api/resources/customer'
require 'lago/api/resources/event'
require 'lago/api/resources/fee'
require 'lago/api/resources/finalized_invoice'
require 'lago/api/resources/gross_revenue'
require 'lago/api/resources/group'
require 'lago/api/resources/invoice'
require 'lago/api/resources/invoiced_usage'
require 'lago/api/resources/mrr'
require 'lago/api/resources/organization'
require 'lago/api/resources/outstanding_invoice'
require 'lago/api/resources/plan'
require 'lago/api/resources/subscription'
require 'lago/api/resources/tax'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
module Lago
module Api
module Resources
class OutstandingInvoice < Base
class FinalizedInvoice < Base
def api_resource
'analytics/outstanding_invoices'
'analytics/finalized_invoices'
end

def root_name
'outstanding_invoice'
'finalized_invoice'
end
end
end
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"outstanding_invoices": [
"finalized_invoices": [
{
"month": "2023-11-01T00:00:00.000Z",
"payment_status": "pending",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

require 'spec_helper'

RSpec.describe Lago::Api::Resources::OutstandingInvoice do
RSpec.describe Lago::Api::Resources::FinalizedInvoice do
subject(:resource) { described_class.new(client) }

let(:client) { Lago::Api::Client.new }
Expand All @@ -16,39 +16,39 @@
end

describe '#get_all' do
let(:outstanding_invoices_response) { load_fixture('outstanding_invoice_index') }
let(:finalized_invoices_response) { load_fixture('finalized_invoice_index') }

context 'when there is no options' do
before do
stub_request(:get, 'https://api.getlago.com/api/v1/analytics/outstanding_invoices')
.to_return(body: outstanding_invoices_response, status: 200)
stub_request(:get, 'https://api.getlago.com/api/v1/analytics/finalized_invoices')
.to_return(body: finalized_invoices_response, status: 200)
end

it 'returns gross revenue' do
response = resource.get_all

expect(response['outstanding_invoices'].first['currency']).to eq('EUR')
expect(response['outstanding_invoices'].first['amount_cents']).to eq(100)
expect(response['finalized_invoices'].first['currency']).to eq('EUR')
expect(response['finalized_invoices'].first['amount_cents']).to eq(100)
end
end

context 'when options are present' do
before do
stub_request(:get, 'https://api.getlago.com/api/v1/analytics/outstanding_invoices?currency=EUR')
.to_return(body: outstanding_invoices_response, status: 200)
stub_request(:get, 'https://api.getlago.com/api/v1/analytics/finalized_invoices?currency=EUR')
.to_return(body: finalized_invoices_response, status: 200)
end

it 'returns gross revenue' do
response = resource.get_all({ currency: 'EUR' })

expect(response['outstanding_invoices'].first['currency']).to eq('EUR')
expect(response['outstanding_invoices'].first['amount_cents']).to eq(100)
expect(response['finalized_invoices'].first['currency']).to eq('EUR')
expect(response['finalized_invoices'].first['amount_cents']).to eq(100)
end
end

context 'when there is an issue' do
before do
stub_request(:get, 'https://api.getlago.com/api/v1/analytics/outstanding_invoices')
stub_request(:get, 'https://api.getlago.com/api/v1/analytics/finalized_invoices')
.to_return(body: error_response, status: 422)
end

Expand Down
2 changes: 1 addition & 1 deletion spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@
require 'lago/api/resources/customer'
require 'lago/api/resources/event'
require 'lago/api/resources/fee'
require 'lago/api/resources/finalized_invoice'
require 'lago/api/resources/gross_revenue'
require 'lago/api/resources/group'
require 'lago/api/resources/invoice'
require 'lago/api/resources/invoiced_usage'
require 'lago/api/resources/mrr'
require 'lago/api/resources/organization'
require 'lago/api/resources/outstanding_invoice'
require 'lago/api/resources/plan'
require 'lago/api/resources/subscription'
require 'lago/api/resources/tax'
Expand Down

0 comments on commit f8e94b9

Please sign in to comment.