RDS: Allow more db-instance operations in custom subnets #8440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this failed with
TypeError: cannot pickle 'generator' object
when the code tried to deepcopy the `database.db_subnet_group`.
But a deepcopy isn't needed in this case, the subsequent
database.master_user_secret_status = ...
will not affect the shallow copy. Also, the copy is only needed
to render the response template.
Previously, this failed with
TypeError: cannot pickle 'generator' object
when the code tried to deepcopy the `backend`.
Merge it with the existing code that removed "db_subnet_group".
|
Hmm, the test failures seem to be unrelated to my changes. |
Yeah, they are unrelated. That's due to a recent bug in botocore, so don't worry about them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #8374 that fixes a new
deepcopycall from #8373 inmodify_db_instanceand another one inrestore_db_instance_to_point_in_time. Previously, this failed withTypeError: cannot pickle 'generator' object