-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github actions don't run on PRs from forks #1308
Comments
Made this as as a placeholder and hadn't had a chance to come back! The goal is for all checks including github actions to run for PRs made on the forks of contributors to the organization (e.g. @alxndrsn). Running checks for PRs from forks of contributors outside the org should require maintainer approval (at least the first time for each individual) -- https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/approving-workflow-runs-from-public-forks |
👍 I would guess workflow configs should change something like the following: -on: push
+on:
+ push:
+ branches: master
+ pull_request: |
I think we'd like to run on all branches. Here's someone with the same issue: https://github.com/szabgab/github-actions-avoid-duplicate-trigger?tab=readme-ov-file They point to https://github.com/marketplace/actions/skip-duplicate-actions which seems reasonable. There's also https://github.com/orgs/community/discussions/57827 Maybe take a quick look and see if either of those seems reliable and reasonable? If not, I think we just live with the double runs like we do with pyxform. |
A PR from @ktuite on this repo ran 7 checks including Github actions: 2e76ed0
A PR from @alxndrsn on his fork only ran the build step in CircleCI: 54f10ce
Ideally all checks would run for forks of members of the organization and would require authorization for folks coming from outside the organization. That's how our other repos are set up.
The text was updated successfully, but these errors were encountered: