Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run github actions on pull requests #1315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Dec 3, 2024

Closes #1308

There is some subtlety here:

  • to allow personal development branches, exceptions can be included. As @ktuite names branches consistently, I've included that exception here. For other contributors, they could pick a naming scheme and add to the config
  • i don't think soak tests need to run on every PR, so they're restricted to master, and also can be triggered manually from https://github.com/getodk/central-backend/actions

What has been done to verify that this works as intended?

It's not always 100% possible to test github actions config without merging it.

Why is this the best possible solution? Were any other approaches considered?

See #1308 for alternative suggestions(s).

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

No.

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

No.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

@lognaturel
Copy link
Member

Won't this end up with duplicate runs for the branches that are marked as exceptions? Why not one of the alternatives in the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github actions don't run on PRs from forks
2 participants