test/util/zip: processZipFile(): prevent filename clashes #1310
+142
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separating file data and meta data prevents clashes for files with names including: * `filenames` * `toString` * etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separating file data and meta data prevents clashes for files with names including:
filenamestoStringMotivation
Working on #1309, the return value from
httpZipResponseToFiles()was confusing as it mixes both zipfile contents and zipfile metadata in the same object. This PR aims to ease use ofhttpZipResponseToFiles().PR template
What has been done to verify that this works as intended?
Ran tests.
Why is this the best possible solution? Were any other approaches considered?
This change was prompted by difficulties in understanding the results of
httpZipResponseToFiles()when writing new zip-based tests.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Only affects developers; hopefully change is intuitive and improves understanding.
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
No.
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass OR confirm CircleCI build passes