Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: allow configuring S3_REGION #1357

Closed
wants to merge 17 commits into from
+129 −29
Closed

backend: allow configuring S3_REGION #1357

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
90d1886
backend: allow configuring S3_REGION
Jan 13, 2025
9500234
add region when creating bucket
Jan 13, 2025
fac48ac
makeBucket() with/without region
Jan 13, 2025
8b3774b
shift NODE_CONFIG_ENV passing
Jan 13, 2025
08917b8
don't re-specify env
Jan 13, 2025
ef05e96
add server ports
Jan 13, 2025
f08a4c8
proper arrays
Jan 13, 2025
6ae89ce
add @smoke-test
Jan 13, 2025
453ebbe
remove extra cleanup stage
Jan 13, 2025
4b48213
remove more unnecessary cleanup
Jan 13, 2025
fa466aa
neater error
Jan 13, 2025
be81716
try to break the region
Jan 13, 2025
c9a8200
fx
Jan 13, 2025
d23c9a5
fix JSON
Jan 13, 2025
962755d
resolve TODOs; improve logging
Jan 13, 2025
fa4c533
remove new configs
Jan 13, 2025
ee5a395
use a more normal region
Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
neater error
alxndrsn committed Jan 13, 2025
commit fa466aad77d4632a9de364c522d99655ad8eee02
2 changes: 1 addition & 1 deletion test/e2e/s3/run-tests.sh
View file
Original file line number Diff line number Diff line change
@@ -55,7 +55,7 @@ run_suite() {
case "$suite" in
smoke) testOptions=(--fgrep @smoke-test) ;;
all) testOptions=() ;;
*) log "Unrecongised test suite: $suite"; exit 1 ;;
*) log "!!! Error: unrecongised test suite: $suite"; exit 1 ;;
esac

NODE_CONFIG_ENV="$configEnv" node lib/bin/s3-create-bucket.js