Extend randomize seed tests #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to add on the empty case here as well? |
|
Yes, that, I want. |
lognaturel
approved these changes
Oct 23, 2024
lognaturel
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests in #804 could serendipitously
failsucceed while they shouldn't since randomization took place over only 2 items (thus randomize(x, y) would result in the same shuffled order with probability 0.5 when varying y).This expands tests to use a larger collection so that entropy is
8!rather than 2 when the total ordering rather than just the identity of the first element of the shuffled list is tested (reducing the "lucky factor" to 1/40320 if I'm not mistaken).Update: Preserved classic behaviour for the special case of zero-length strings as seed input, and added/modified tests for that behaviour.