Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

77: add statement on Central compatibility #80

Merged
merged 1 commit into from
May 2, 2024

Conversation

lindsay-stevens
Copy link
Contributor

Closes #77

What has been done to verify that this works as intended?

Tested pyODK with v2024.1.0 as deployed on https://staging.getodk.cloud/

Why is this the best possible solution? Were any other approaches considered?

See #77

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Advises users on expected compatibility with Central.

Do we need any specific form for testing your changes? If so, please attach one.

N/A

Does this change require updates to documentation? If so, please file an issue here and include the link below.

N/A

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests
  • run python -m unittest and verified all tests pass
  • run ruff format pyodk tests and ruff check pyodk tests to lint code
  • verified that any code or assets from external sources are properly credited in comments

@lindsay-stevens lindsay-stevens requested a review from lognaturel May 2, 2024 07:48
@yanokwa
Copy link
Member

yanokwa commented May 2, 2024

We should add updating this text to the release section of the read me.

@lognaturel lognaturel merged commit 62f49e3 into getodk:master May 2, 2024
4 checks passed
@lindsay-stevens lindsay-stevens deleted the pyodk-77 branch May 3, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we do something more thoughtful when a new Central API method is called against an older server?
3 participants