templates: add optional Series ID buttons to the patch list #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossburton
force-pushed
the
patchlist-copy
branch
from
20069f6
to
57efa60
Compare
|
Now tested! Had to use a nbsp to stop "Series ID" wrapping and ruining the header alignment. 
|
|
I'm torn on whether the column should just be called "ID" and let its position clarify what ID it refers to. |
|
Maybe the ID column should just be removed, and the button inline with the patch or series name? |
|
I wonder if, rather than adding another column, we could add the |
If the user has turned on display of patch IDs, add clickable series ID buttons inline with the series name. Signed-off-by: Ross Burton <[email protected]>
rossburton
force-pushed
the
patchlist-copy
branch
from
57efa60
to
d80dc15
Compare
|
Done.
Would it be sensible to merge the "Patch ID" and "Patch" columns too? |
|
The good thing about two columns is it forces the alignment... |
|
Polite ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has turned on display of patch IDs, add another column with the series IDs to the patch list template.
Note that I've not tested this in production because I've not yet setup a local instance...