Add magic link to open patches in user's mail client #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to https://gitlab.gnome.org/GNOME/evolution/-/issues/2618, the necessary change to Evolution's .desktop file is in 3.51.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many mail clients support opening specific mails using a special URL scheme. Because engineers are engineers, obviously there is more than one standard here. For example, Evolution uses
mid:<messageid>and macOS Mail usesmessage:<messageid>.If the user specifies what URL scheme they prefer, then patchwork can add buttons that will open the relevant mail directly in the user's mailer (assuming they have it). It looks like this:
Clicking the "open in new window" button opens the mail in my client like magic! This makes replying to patches actually easy, which is nice for a change.
Marking as a draft as the commit messages need work and I'd like feedback from the maintainers, but this does actually work.