Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue #507] Allow non delegate users to declare interest in a patch #588

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[Issue #507] Allow non delegate users to declare interest in a patch #588

wants to merge 8 commits into from

Commits on Apr 16, 2024

  1. models: add fields to allow non delegate users to declare intention t… 

    …o review a patch

Users interested in reviewing a Patch are linked by the `planning_to_review` attribute on a Patch through
the PatchReviewIntention model.
Also added a field to State to indicate how long a review intention can last before it expires

Signed-off-by: andrepapoti <[email protected]>
    @andrepapoti
    andrepapoti committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    b6c9b30 View commit details
    Browse the repository at this point in the history

  2. permissions: create a PatchDetailPermission to allow non delegate use… 

    …rs to edit it

Signed-off-by: andrepapoti <[email protected]>
    @andrepapoti
    andrepapoti committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    1f81a0e View commit details
    Browse the repository at this point in the history

  3. api: Update Patch related serializers to accomodate for the new 'plan… 

    …ning_to_review' field

Signed-off-by: andrepapoti <[email protected]>
    @andrepapoti
    andrepapoti committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    b6b4989 View commit details
    Browse the repository at this point in the history

  4. tests: add tests for users declaring intention to review a patch 

    Signed-off-by: andrepapoti <[email protected]>
    @andrepapoti
    andrepapoti committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9890f64 View commit details
    Browse the repository at this point in the history

  5. models: Override 'create' for PatchComment to automatically remove th… 

    …e PatchReviewIntention for the commenting user

Signed-off-by: andrepapoti <[email protected]>
    @andrepapoti
    andrepapoti committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    81ffed2 View commit details
    Browse the repository at this point in the history

  6. forms: update MuliplePatchForm to acocmodate for the new 'planning_to… 

    …_review' field

Signed-off-by: andrepapoti <[email protected]>
    @andrepapoti
    andrepapoti committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    6005c30 View commit details
    Browse the repository at this point in the history

  7. serializers: Optimize query performance on PatchDetailSerializer for … 

    …'patchinterest'

Signed-off-by: andrepapoti <[email protected]>
    @andrepapoti
    andrepapoti committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    909fb55 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. web: add cron service to update 'has_planned_review' field on patches 

    Signed-off-by: andrepapoti <[email protected]>
    @andrepapoti
    andrepapoti committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    1001da9 View commit details
    Browse the repository at this point in the history