[Issue #441] Add maintainer notes to patches - alternative solution #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comments with an empty msgid will be considered maintainer notes. - Only able to create through the API - Only one maintainer note per patch/cover - Maintainers can edit other notes Signed-off-by: Victor Accarini <[email protected]>
- Add create maintainer note requests - Update Comment to allow empty msgid Signed-off-by: Victor Accarini <[email protected]>
Signed-off-by: Victor Accarini <[email protected]>
Comments with an empty msgid are now considered maintainer notes, maintainers should be able to create and update notes for cover and patches. Signed-off-by: Victor Accarini <[email protected]>
Signed-off-by: Victor Accarini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution reuses the CoverComment and PatchComment models instead of creating a new resource.
Differences:
See #586 for reference discussion