Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically remove orphans when running make up #7164

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

justinclift
Copy link
Member

What type of PR is this?

  • Other

Description

This is just a trivial quality of life improvement PR for Redash developers.

It adds the --remove-orphans option to the make up docker compose commands, to automatically remove orphaned containers from previous runs.

Without this option make up will commonly display a warning about orphaned containers:

WARN[0000] Found orphan containers ([redash-server-run-9d298b8fca7f]) for this project. If you
removed or renamed this service in your compose file, you can run this command with the
--remove-orphans flag to clean it up.

How is this tested?

  • Manually

Seems to work fine in my local development environment, and doesn't change any of our build nor running code. In theory (!), this shouldn't cause any issues.

Copy link
Member

@lucydodo lucydodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. approve and merge.
However, if we configure multiple compose file in the future, we might want to think twice about that option.

@lucydodo lucydodo enabled auto-merge (squash) September 17, 2024 05:04
@lucydodo lucydodo merged commit c42b151 into master Sep 17, 2024
14 checks passed
@justinclift
Copy link
Member Author

Oh yeah, good point. I guess we'll rediscover this then. 😄

@justinclift justinclift deleted the remove_orphans_v1 branch September 17, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants