Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move restyled to a github action #7191

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Move restyled to a github action #7191

merged 1 commit into from
Oct 16, 2024

Conversation

eradman
Copy link
Collaborator

@eradman eradman commented Oct 15, 2024

What type of PR is this?

  • CI/Workflow

Description

#7186 did not pass the restyle check because this app is no longer supported

restyled — The Restyled App has been disabled

This PR introduces a github action as recommended in https://docs.restyled.io/docs/migrating-to-github-actions/

How is this tested?

  • Manually

Created PR on personal fork of Redash

https://github.com/eradman/redash/actions/runs/11349876573/job/31566996359

@eradman
Copy link
Collaborator Author

eradman commented Oct 15, 2024

I made one change that differs from what the restyle.io docs suggest:

--- a/.github/workflows/restyled.yml
+++ b/.github/workflows/restyled.yml
@@ -13,7 +13,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
         with:
-          ref: ${{ github.event.pull_request.head.ref }}
+          ref: ${{ github.event.pull_request.head.sha }}

@eradman eradman requested a review from arikfr October 15, 2024 16:23
@justinclift
Copy link
Member

@arikfr This one's yours as you'll need to do the Org level stuff to uninstall the Restyled plugin there: https://docs.restyled.io/docs/migrating-to-github-actions/

Copy link
Member

@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this!

@arikfr arikfr merged commit 7c22756 into getredash:master Oct 16, 2024
11 of 12 checks passed
@lucydodo
Copy link
Member

@arikfr We've been facing the same issue with the 'website' repo for a while.
If you install the application there, I can prepare a PR. :)

@eradman eradman deleted the restyled branch October 17, 2024 14:41
@arikfr
Copy link
Member

arikfr commented Oct 27, 2024

@lucydodo I removed the app from all the repos in this org, so I think it should be possible to add to the website same as was done here?

@lucydodo
Copy link
Member

@arikfr Thanks for the confirmation, I created the same PR in the website repo: getredash/website#789

@arikfr
Copy link
Member

arikfr commented Oct 29, 2024

I made one change that differs from what the restyle.io docs suggest:

What was the reason for this change?

I had a Restyled failure on my PR (#7211) and without changing this back to .ref it failed to create the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants