Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the number of leftovers listed #335

Merged
merged 4 commits into from
Dec 15, 2021

Conversation

chadwhitacre
Copy link
Member

Nobody's going to read through a list of 1,000s of commits, may as well use git log at that point.

What's more, over-long changesets can lead to GitHub API failures.

Nobody's going to read through a list of 1,000s of commits, may as well
use git log at that point.
src/utils/__tests__/changelog.test.ts Outdated Show resolved Hide resolved
src/utils/changelog.ts Show resolved Hide resolved
@BYK
Copy link
Member

BYK commented Dec 15, 2021

I don't think you are still immune to body overflow as we can go over the length limit via Milestones. Quite hard but possible, so just noting.

@BYK
Copy link
Member

BYK commented Dec 15, 2021

Also sorry, didn't ever think we'd reach this kind of limit so quickly 😅

@chadwhitacre
Copy link
Member Author

Yes, it's possible with Milestones but less likely, GitHub is capping the POST body at 125,000 bytes.

And no need to apologize, easy enough to fix. Thanks for reviewing! :)

@chadwhitacre chadwhitacre merged commit 03fda08 into master Dec 15, 2021
@chadwhitacre chadwhitacre deleted the cwlw/limit-number-of-leftovers-listed branch December 15, 2021 23:23
@jan-auer
Copy link
Member

jan-auer commented Jan 17, 2022

I'm afraid this didn't work, at least the last release still contained >2000 lines from the changelog. I'll check if we forgot to bump the version in the publish repository (i.e. what's "latest". Edit: The fix was pushed to latest on Dockerhub).

On another note, I'm not sure how useful it is to list 24 commits out of a list of 1500-2000. Might as well leave it out completely.

Edit: Eureka! While publish uses the latest published craft, the release action uses the latest released craft.

@chadwhitacre
Copy link
Member Author

While publish uses the latest published craft, the release action uses the latest released craft.

getsentry/publish#666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants