-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit the number of leftovers listed #335
Conversation
Nobody's going to read through a list of 1,000s of commits, may as well use git log at that point.
I don't think you are still immune to body overflow as we can go over the length limit via Milestones. Quite hard but possible, so just noting. |
Also sorry, didn't ever think we'd reach this kind of limit so quickly 😅 |
Yes, it's possible with Milestones but less likely, GitHub is capping the POST body at 125,000 bytes. And no need to apologize, easy enough to fix. Thanks for reviewing! :) |
I'm afraid this didn't work, at least the last release still contained >2000 lines from the changelog. I'll check if we forgot to bump the version in the publish repository (i.e. what's "latest". Edit: The fix was pushed to latest on Dockerhub). On another note, I'm not sure how useful it is to list 24 commits out of a list of 1500-2000. Might as well leave it out completely. Edit: Eureka! While publish uses the latest published craft, the release action uses the latest released craft. |
|
Nobody's going to read through a list of 1,000s of commits, may as well use git log at that point.
What's more, over-long changesets can lead to GitHub API failures.