Skip to content

chore(nuget): clarify publish behavior reentrant #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore(nuget): clarify publish behavior reentrant #619

wants to merge 2 commits into from

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Oct 1, 2025 •
edited
Loading

bruno-garcia
bruno-garcia commented Oct 1, 2025
View reviewed changes
@bruno-garcia bruno-garcia requested a review from BYK October 2, 2025 14:08
BYK
BYK requested changes Oct 2, 2025
View reviewed changes
Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the very quick turn around.

Can we also add a comment to the code where we added this behavior as people working on Craft tend not to read the huge readme 😅

@bruno-garcia @BYK
Update README.md
77386cc 
Co-authored-by: Burak Yigit Kaya <[email protected]>
@bruno-garcia bruno-garcia requested a review from BYK October 2, 2025 18:55
@bruno-garcia
Copy link
Member Author

Can we also add a comment to the code where we added this behavior as people working on Craft tend not to read the huge readme 😅

The diff was only the --skip-duplicate which I'd argue is redundant, so IMO with the README note it's quite clear to anyone touching this in the future, or running it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BYK BYK Awaiting requested review from BYK

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bruno-garcia @BYK