Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

Add SDK features to event payload #1244

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Add SDK features to event payload #1244

merged 1 commit into from
Apr 24, 2024

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Apr 23, 2024

Add a new field features to the SDK event payload, which is handy for tracking the adoption of features.

This is for getsentry/team-sdks#83.

Add a new field features to the sdk event payload, which is handy for
tracking the adoption of features.
Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
develop ✅ Ready (Inspect) Visit Preview Apr 23, 2024 7:11am

Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should become a context, which is much simpler to add to SDKs compared to making changes to the transaction.

@philipphofmann
Copy link
Member Author

This should become a context, which is much simpler to add to SDKs compared to making changes to the transaction.

@cleptric, I don't understand what exactly you mean by making changes to the transaction. Why is this a problem? Extending the SDK interface on Cocoa, for example, is straightforward.

Adding SDK features to the SDK interface, which contains the SDK name, SDK version, SDK integrations, and SDK packages, is a coherent approach. That's why I chose it over the context.

@cleptric
Copy link
Member

I misread the example, all good!

@philipphofmann philipphofmann merged commit da2bdf8 into master Apr 24, 2024
5 checks passed
@philipphofmann philipphofmann deleted the feat/sdk-features branch April 24, 2024 09:03
philipphofmann added a commit to getsentry/relay that referenced this pull request Apr 24, 2024
This PR adds features to the ClientSDKInfo. Related develop docs PR:
getsentry/develop#1244.
philipphofmann added a commit to getsentry/relay that referenced this pull request Apr 25, 2024
This PR adds features to the ClientSDKInfo. Related develop docs PR:
getsentry/develop#1244 and team SDK GH issue:
getsentry/team-sdks#83.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants