Skip to content

Commit

Permalink
fix(buffer): Ignore dropped global config watch (#4071)
Browse files Browse the repository at this point in the history
`rx.changed().await` on a watch will return an error if the sender has
been dropped. This can cause the envelope buffer service loop to
busy-loop on shutdown.
  • Loading branch information
jjbayer authored Sep 24, 2024
1 parent 50791c6 commit 385cc89
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion relay-server/src/services/buffer/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ impl Service for EnvelopeBufferService {
break;
}
}
_ = global_config_rx.changed() => {
Ok(()) = global_config_rx.changed() => {
relay_log::trace!("EnvelopeBufferService: received global config");
sleep = Duration::ZERO;
}
Expand Down

0 comments on commit 385cc89

Please sign in to comment.