Skip to content

Commit

Permalink
feat(spans): Ingest a duration_light metric tagged the same way exclu…
Browse files Browse the repository at this point in the history
…sive_time_light is (#3772)
  • Loading branch information
phacops authored Jul 16, 2024
1 parent ce5520b commit b561ec3
Show file tree
Hide file tree
Showing 8 changed files with 3,616 additions and 219 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
- Remove experimental double-write from spans to transactions. ([#3801](https://github.com/getsentry/relay/pull/3801))
- Add feature flag to disable replay-video events. ([#3803](https://github.com/getsentry/relay/pull/3803))
- Write the envelope's Dynamic Sampling Context (DSC) into event payloads for debugging. ([#3811](https://github.com/getsentry/relay/pull/3811))
- Extract a duration light metric for spans without a transaction name tag. ([#3772](https://github.com/getsentry/relay/pull/3772))

## 24.6.0

Expand Down
348 changes: 182 additions & 166 deletions relay-dynamic-config/src/defaults.rs

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion relay-server/src/metrics_extraction/event.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1711,7 +1711,7 @@ mod tests {
None,
);

assert_eq!(metrics.len(), 4);
assert_eq!(metrics.len(), 5);

assert_eq!(&*metrics[0].name, "c:spans/usage@none");

Expand All @@ -1730,6 +1730,7 @@ mod tests {
);

assert_eq!(&*metrics[3].name, "d:spans/duration@millisecond");
assert_eq!(&*metrics[4].name, "d:spans/duration_light@millisecond");
}

#[test]
Expand Down
Loading

0 comments on commit b561ec3

Please sign in to comment.