-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cardinality): Track exceeded CardinalityLimit for each bucket #3825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
reviewed
Jul 18, 2024
loewenheim
commented
Jul 18, 2024
loewenheim
commented
Jul 18, 2024
Update: we now only store one limit per |
Dav1dde
approved these changes
Jul 18, 2024
That impl doesn't really make much sense for a single limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3806.
Outcome::CardinalityLimited
now contains the IDs of theCardinalityLimit
s that were exceeded. We use aSmallVec<[String; 4]>
for this (4 chosen essentially at random—please advise on what a sensible number would be here).We track which cardinality limits are exceeded by a bucket in
DefaultReporter
. This tracking propagates throughCardinalityLimits
toCardinalityLimitsSplit
, which gains a new fieldexceeded_limits
. Finally, incardinality_limit_buckets
, we now calltrack
with each bucket individually—each of them has a different outcome with different exceeded limits, so it's not possible to do this in bulk.