ref(processor): Remove the config from the state #4393
Conversation
iambriccardo
changed the title
| } | ||
|
|
||
| /// New type representing the normalization state of the event. | ||
| #[derive(Copy, Clone)] |
There was a problem hiding this comment.
Just moved everything.
| /// based on a feature flag. | ||
| /// | ||
| /// If the project config did not come from the upstream, we keep the items. | ||
| fn should_filter(config: &Config, feature: Feature, project_info: &ProjectInfo) -> bool { |
There was a problem hiding this comment.
Arguably you could just pass the mode in here, since that's the only relevant part of the config. This extends up to the callers of this function.
There was a problem hiding this comment.
nit: The argument list is now the feature sandwiched by two configs, I would either choose (config, project_info, feature) or (feature, config, project_info).
There was a problem hiding this comment.
Will do! I did the same for other functions, thanks for the nit!
| @@ -72,6 +72,7 @@ pub fn validate_and_set_dsc( | |||
| /// Computes the sampling decision on the incoming event | |||
| pub fn run<Group>( | |||
| state: &mut ProcessEnvelopeState<Group>, | |||
| config: Arc<Config>, | |||
There was a problem hiding this comment.
Likewise, I believe this can just be processing_enabled: bool.
Yes, this is a great comment. I plan to improve those things in a second pass. Right now I am aiming for chirurgical changes. |
iambriccardo
force-pushed
the
riccardo/ref/remove-state-field-6
branch
from
060fe31 to
a133f4f
Compare
This PR removes the
configfrom the processor state.#skip-changelog