Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(processor): Remove form data envelope items #4428

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

iambriccardo
Copy link
Member

@iambriccardo iambriccardo commented Jan 7, 2025

This PR removes form data envelope items whenever a standalone envelope is processed. This fixes an issue where we were attempting to write form data items to Kafka, which are not supported.

Closes: #3359

@iambriccardo iambriccardo changed the title riccardo/fix/form data fix(processor): Remove form data envelope types Jan 7, 2025
@iambriccardo iambriccardo marked this pull request as ready for review January 7, 2025 14:49
@iambriccardo iambriccardo requested a review from a team as a code owner January 7, 2025 14:49
@iambriccardo iambriccardo changed the title fix(processor): Remove form data envelope types fix(processor): Remove form data envelope items Jan 7, 2025
relay-server/src/services/processor/standalone.rs Outdated Show resolved Hide resolved
Comment on lines 7 to 8
/// This function removes form data items from the envelope since they are not needed for
/// standalone processing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// This function removes form data items from the envelope since they are not needed for
/// standalone processing.
/// This function removes form data items from the envelope since they are not allowed in
/// standalone processing.

@iambriccardo iambriccardo enabled auto-merge (squash) January 7, 2025 15:09
@iambriccardo iambriccardo merged commit ad26c42 into master Jan 7, 2025
23 checks passed
@iambriccardo iambriccardo deleted the riccardo/fix/form-data branch January 7, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form Data events are dropped
2 participants