feat(links): write span links to Kafka #4601
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Span links were added in <PR>, but are currently only accessible as part of transaction events. We would like to get them in EAP. The first step in that process is to add them to serialized Kafka spans. The integration tests confirm production into Kafka for every current path for links to enter the system: - in a transaction event's trace context - in a transaction event's child spans - in a `span` envelope item - in an `otel_span` envelope item - via OTLP JSON - via OTLP gRPC Co-authored-by: Lukas Stracke <[email protected]> Co-authored-by: Sigrid Huemer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is a draft until we discuss span schema a bit further - if the schema is going to change we shouldn't create even more things to migrate by encoding links a possibly outdated way in Kafka. EAP isn't ready to start writing links into ClickHouse yet anyway.
Span links were added in #4486, but are currently only accessible as part of transaction events. We would like to get them in EAP. The first step in that process is to add them to serialized Kafka spans.
The integration tests confirm production into Kafka for every current path for links to enter the system:
spanenvelope itemotel_spanenvelope itemNote that our version of the
opentelemetry-protoPython library is too old to makeflagsavailable so not all tests could check thesampledhandling. I'll handle that in a future PR.