-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid duplicating Breadcrumbs on Android #254
Conversation
Pay attention at getsentry/team-mobile#11 (comment) |
I have tried to use the SentryEnvelope to read the byte array generated by the SDK. EnvelopeReader reader = new EnvelopeReader(options.getSerializer());
InputStream targetStream = new ByteArrayInputStream(envelope.getBytes(Charset.forName("UTF-8")));
SentryEnvelope javaEnvelope = reader.read(targetStream);
hub.captureEnvelope(javaEnvelope); The envelope was captured but now the envelope is different from the previously ones, for example:
|
@lucas-zimerman the event is enriched with device context after its being written in the disk (by a file observer), that's how it works on Android and it should not, that's the reason about getsentry/team-mobile#11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
One thing to note - we should add a comment to getsentry/team-mobile#11 that the changes of this PR need to be revisited/reverted once getsentry/team-mobile#11 is done.
hi,guys, I am using sentry-cordova and have sometimes double breadcrubms, can we do something with that ? I do not see similar fix for sentry-cordova project |
Unhandled Exceptions doesn't crash the app, unlike React Native, so we shouldn't validate the Handled flag for clearing the breadcrumbs.
For context: Both SDKs have the same Breadcrumbs, we clear them on the Android Wrapper because the Android SDK will apply the same breadcrumbs to the captured event.
Fixes #232