feat: Prepare for Android alpha + refactor the SDK to be used in conjunction with @sentry/angular #35
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| { | ||
| "editor.formatOnType": true, | ||
| "editor.formatOnPaste": false, | ||
| "editor.formatOnSave": true, | ||
| "editor.rulers": [ | ||
| 120 | ||
| ], | ||
| "editor.tabSize": 2, | ||
| "files.autoSave": "onWindowChange", | ||
| "files.trimTrailingWhitespace": true, | ||
| "files.insertFinalNewline": true, | ||
| "search.exclude": { | ||
| "**/node_modules/": true, | ||
| "**/build/": true, | ||
| "**/dist/": true | ||
| }, | ||
| "typescript.tsdk": "./node_modules/typescript/lib", | ||
| "editor.codeActionsOnSave": { | ||
| "source.fixAll": true | ||
| }, | ||
| "[json]": { | ||
| "editor.formatOnType": false, | ||
| "editor.formatOnPaste": false, | ||
| "editor.formatOnSave": false | ||
| }, | ||
| "react-native-tools.projectRoot": "./sample" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import { NgModule, ErrorHandler } from '@angular/core'; | ||
| import { BrowserModule } from '@angular/platform-browser'; | ||
| import { RouteReuseStrategy } from '@angular/router'; | ||
|
|
||
|
|
@@ -7,30 +7,54 @@ import { SplashScreen } from '@ionic-native/splash-screen/ngx'; | |
| import { StatusBar } from '@ionic-native/status-bar/ngx'; | ||
|
|
||
| import * as Sentry from '@sentry/capacitor'; | ||
| import { init as sentryAngularInit, createErrorHandler } from '@sentry/angular'; | ||
| import { Integrations } from '@sentry/tracing'; | ||
|
|
||
| import { AppRoutingModule } from './app-routing.module'; | ||
| import { AppComponent } from './app.component'; | ||
|
|
||
| // ATTENTION: Change the DSN below with your own to see the events in Sentry. Get one at sentry.io | ||
| Sentry.init( | ||
| { | ||
| dsn: | ||
| 'https://[email protected]/5522756', | ||
| // An array of strings or regexps that'll be used to ignore specific errors based on their type/message | ||
| ignoreErrors: [/MiddleEarth_\d\d/, 'RangeError'], | ||
| // Debug mode with valuable initialization/lifecycle information | ||
| debug: true, | ||
| // Whether SDK should be enabled or not | ||
| enabled: true, | ||
| integrations: [new Integrations.BrowserTracing()], | ||
| // A release identifier | ||
| release: '1.0.0', | ||
| dist: "1.0.0.1", | ||
| // An environment identifier | ||
| environment: 'staging', | ||
| // We recommend adjusting this value in production, or using tracesSampler | ||
| // for finer control | ||
| tracesSampleRate: 1.0, | ||
| }, | ||
| sentryAngularInit, | ||
| ); | ||
|
|
||
| // /** | ||
| // * Wrap the ionic error handler with this method so Sentry catches unhandled errors on ionic. | ||
| // * See the documentation for more details. | ||
| // */ | ||
| // const withSentryIonicErrorHandler = <C extends new (...args: any[]) => any>( | ||
| // IonicErrorHandler: C, | ||
| // ): C => { | ||
| // class SentryIonicErrorHandler extends IonicErrorHandler { | ||
| // handleError(error: any) { | ||
| // super.handleError(error); | ||
| // Sentry.captureException(error.originalError ?? error); | ||
| // } | ||
| // } | ||
|
|
||
| // return SentryIonicErrorHandler; | ||
| // }; | ||
|
|
||
| // const SentryIonicErrorHandler = withSentryIonicErrorHandler(ErrorHandler); | ||
jennmueng marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| @NgModule({ | ||
| declarations: [AppComponent], | ||
|
|
@@ -39,8 +63,12 @@ Sentry.init({ | |
| providers: [ | ||
| StatusBar, | ||
| SplashScreen, | ||
| { provide: RouteReuseStrategy, useClass: IonicRouteStrategy }, | ||
| { | ||
| provide: ErrorHandler, | ||
| useValue: createErrorHandler(), | ||
| }, | ||
| ], | ||
| bootstrap: [AppComponent], | ||
| }) | ||
| export class AppModule {} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,23 @@ | ||
| <ion-header [translucent]="true"> | ||
| <ion-toolbar> | ||
| <ion-title> Crashes </ion-title> | ||
| </ion-toolbar> | ||
| </ion-header> | ||
|
|
||
| <ion-content [fullscreen]="true"> | ||
| <ion-header collapse="condense"> | ||
| <ion-toolbar> | ||
| <ion-title size="large">Crashes</ion-title> | ||
| </ion-toolbar> | ||
| </ion-header> | ||
|
|
||
| <section class="button-container"> | ||
| <label> | ||
| Native Crash | ||
| <ion-button (click)="nativeCrash()" | ||
| >Crash</ion-button | ||
| > | ||
| </label> | ||
|
|
||
| </section> | ||
| </ion-content> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,16 @@ | ||
| import { Component } from '@angular/core'; | ||
|
|
||
| import * as Sentry from '@sentry/capacitor'; | ||
|
|
||
| @Component({ | ||
| selector: 'app-tab3', | ||
| templateUrl: 'tab3.page.html', | ||
| styleUrls: ['tab3.page.scss'], | ||
| }) | ||
| export class Tab3Page { | ||
| constructor() {} | ||
|
|
||
| public nativeCrash(): void { | ||
| Sentry.nativeCrash(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
side note: bump the Android SDK to the latest GA, 5.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, after this PR I'll make one to bump Android and another to bump JS