Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump Sentry for iOS (sentry-cocoa) to 8.8.0 #397

Merged
merged 6 commits into from
Jun 29, 2023
Merged

build(deps): bump Sentry for iOS (sentry-cocoa) to 8.8.0 #397

merged 6 commits into from
Jun 29, 2023

Conversation

Zapominacz
Copy link
Contributor

@Zapominacz Zapominacz commented Jun 26, 2023 •
edited
Loading

Additionaly, fixed formatting issues in plist files

closes #396

@Zapominacz
build(deps): bump Sentry for iOS to 8.8.0
c8e3b89 
Fixed formatting issues in plist files
@bruno-garcia
Copy link
Member

bruno-garcia commented Jun 26, 2023 •
edited
Loading

There are really no breaking changes?
The PR for RN was quite large: getsentry/sentry-react-native#2707

@Zapominacz
Copy link
Contributor Author

@bruno-garcia You are right - I forgot to change it in ios/Podfile. I will repair it as soon as possible

@Zapominacz
Copy link
Contributor Author

@bruno-garcia Have some issues with PrivateSentrySDKOnly - should work now. Added [weak self] to closures to prevent retain cycles

@Zapominacz
Copy link
Contributor Author

I've rechecked all example apps and performed some adjustments

bruno-garcia
bruno-garcia approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @brustolin

brustolin
brustolin approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bruno-garcia bruno-garcia merged commit 7a36a73 into getsentry:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brustolin brustolin brustolin approved these changes

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Sentry for iOS (sentry-cocoa) from 7.27.1 to 8.8.0
4 participants
@Zapominacz @bruno-garcia @brustolin @lucas-zimerman