Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dependencies sentry #423

Closed
wants to merge 1 commit into from
Closed

Conversation

TartanLeGrand
Copy link

For fix the dependencies if we are in monorepo.

This version of Sentry Capacitor is incompatible with the following installed packages:
@sentry/tracing version ^7.60.1
@sentry/vue version ^7.60.1
Please install the mentioned packages exactly with version 7.54.0 and with the argument --update-sentry-capacitor
yarn add --exact @sentry/[email protected] @sentry/[email protected]  --update-sentry-capacitor

"@sentry/vue": "7.56.0"
"@sentry/angular": "^7.56.0",
"@sentry/react": "^7.56.0",
"@sentry/vue": "^7.56.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am aware that it may be annoying, but we planned to only use fixed versions, so instead, I would recommend changing those versions to "7.60.1" instead of "^7.56.0"

This may be mitigated in the future if we do more frequent releases bumping Sentry JavaScript

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you don't follow the sentry official version when they are published

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucas-zimerman what's the reason for this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main reason is we want to make sure that the release of capacitor SDK works with the given Sentry Siblings releases.

Are you not able to install Sentry Capacitor version 0.12.2 with Sentry React 7.56.0?

Copy link
Author

@TartanLeGrand TartanLeGrand Aug 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, but in the semantic versioning the second digit is the minor version, if you don't need the features of the 7.60.x you can stay in 7.56.0 in your minimal dependencies and you still stay compatible with the nexts minor versions.

And we have an monorepo with capacitor and vuejs but we keep our packages up to date. If You need you can go to 7.60.1 with an ^ for keep compatibility with other minors.

@github-actions
Copy link
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@Jorgagu
Copy link

Jorgagu commented Aug 29, 2023

@lucas-zimerman any update ? 🤔

@krystofwoldrich
Copy link
Member

We have discussed this with the team and decided to keep the dependencies locked for now.

The stability of the SDK is a priority for us and locking the exact version of the JS SDK helps with it. We follow semver with our public interfaces, but we also use private APIs in our SDKs that might not be compatible between versions.

This doesn't apply only to JS but also to sentry-java and sentry-cocoa dependencies.

Thank you for bringing this to our attention we will be releasing new versions more frequently to keep up closer to the latest sentry-javascript versions.

@TartanLeGrand
Copy link
Author

How we can have 2 diff versions in a mono repo ?

@maxnowack
Copy link

@krystofwoldrich thanks for taking care of this. This is a good explanation of why version pinning should be maintained.

What would make updating sentry packages easier on our end would be if all packages followed the same versioning scheme. For example, all packages in the sentry-javascript monorepo have the same version number. sentry-capacitor is also used exclusively in the javascript context, but has a different versioning. This makes updating the packages a bit difficult at the moment, since you can't just bump the sentry-javascript version without first checking which is the corresponding sentry-capacitor version.
Maybe it would be an idea to include sentry-capacitor in the monorepo of sentry-javascript (if that makes sense).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants