-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dependencies sentry #423
Conversation
"@sentry/vue": "7.56.0" | ||
"@sentry/angular": "^7.56.0", | ||
"@sentry/react": "^7.56.0", | ||
"@sentry/vue": "^7.56.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am aware that it may be annoying, but we planned to only use fixed versions, so instead, I would recommend changing those versions to "7.60.1" instead of "^7.56.0"
This may be mitigated in the future if we do more frequent releases bumping Sentry JavaScript
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But you don't follow the sentry official version when they are published
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucas-zimerman what's the reason for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main reason is we want to make sure that the release of capacitor SDK works with the given Sentry Siblings releases.
Are you not able to install Sentry Capacitor version 0.12.2 with Sentry React 7.56.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, but in the semantic versioning the second digit is the minor version, if you don't need the features of the 7.60.x you can stay in 7.56.0 in your minimal dependencies and you still stay compatible with the nexts minor versions.
And we have an monorepo with capacitor and vuejs but we keep our packages up to date. If You need you can go to 7.60.1 with an ^ for keep compatibility with other minors.
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
@lucas-zimerman any update ? 🤔 |
We have discussed this with the team and decided to keep the dependencies locked for now. The stability of the SDK is a priority for us and locking the exact version of the JS SDK helps with it. We follow semver with our public interfaces, but we also use private APIs in our SDKs that might not be compatible between versions. This doesn't apply only to JS but also to Thank you for bringing this to our attention we will be releasing new versions more frequently to keep up closer to the latest |
How we can have 2 diff versions in a mono repo ? |
@krystofwoldrich thanks for taking care of this. This is a good explanation of why version pinning should be maintained. What would make updating sentry packages easier on our end would be if all packages followed the same versioning scheme. For example, all packages in the sentry-javascript monorepo have the same version number. sentry-capacitor is also used exclusively in the javascript context, but has a different versioning. This makes updating the packages a bit difficult at the moment, since you can't just bump the sentry-javascript version without first checking which is the corresponding sentry-capacitor version. |
For fix the dependencies if we are in monorepo.