-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error when serializing objects with circular referencing #438
Conversation
Hey thank you for opening the PR! Basically copy the normalise to util/normalise Additionally, we could also add the tests that were used here: |
@lucas-zimerman Not entirely sure if i covered all areas. But I have updated it accordingly to the RN solution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks to to me, thank you for the contribution!
This PR only adds the missing changelog from #438 to the changelog.md file.
* Update CHANGELOG.md This PR only adds the missing changelog from #438 to the changelog.md file. * Update CHANGELOG.md
When trying to serialize an object like this
one will get an error like this
This PR fixes this behavior. A "flattened" output can be seen in the added unit test.