Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref: Run sample update concurrently #655

Merged
merged 22 commits into from
May 27, 2024
Merged

Ref: Run sample update concurrently #655

merged 22 commits into from
May 27, 2024

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented May 23, 2024

Previously the tests of bumping the samples and testing the build was run sequentially, due to the amount of samples we are using the CI for building PRs was getting slower.

The PR implements two changes:

  • Github Actions: a vm for each test, and reuse of the built capacitor package.
  • Local: use the concurrency dependency allowing to build and test all samples in parallel.
    I tried using the concurrency and similar methods to only use a single VM on Github Actions but yarn seems too unstable when installing from multiple sources at the same time so I opted for using the simpler version of just using multiple macos virtual machines.

Measured time: before : 8 minutes, after: 1 minute 30 seconds

  • Minor change:
  • moved the build job to the top since the below jobs depends on it (just a visual change)

#skip-changelog

@lucas-zimerman lucas-zimerman marked this pull request as ready for review May 23, 2024 20:30
package.json Outdated Show resolved Hide resolved
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Just some small nits about white spaces.

Co-authored-by: Krystof Woldrich <[email protected]>
@lucas-zimerman lucas-zimerman merged commit eda3ade into main May 27, 2024
11 checks passed
@lucas-zimerman lucas-zimerman deleted the ref/speedup-test branch May 27, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants