Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use commonjs modules in commonjs build #773

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

maxnowack
Copy link
Contributor

@maxnowack maxnowack commented Nov 7, 2024

resolves #772

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
Your PR looks great! But before merging, could you remove the package-lock.json file?

@maxnowack
Copy link
Contributor Author

@lucas-zimerman Oh, sorry. I accidentally committed the package-lock.json and yarn.lock files. I've just updated my commit to only include the desired changes 🙂

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@lucas-zimerman lucas-zimerman merged commit 83a59fc into getsentry:main Nov 12, 2024
12 checks passed
@maxnowack maxnowack deleted the patch-1 branch November 12, 2024 06:26
@maxnowack
Copy link
Contributor Author

@lucas-zimerman is there an ETA for when this change will be released? 🙂
It's currently blocking us from upgrading to sentry v8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CommonJS build contains ESM code
2 participants