Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sdk version to user agent string #3713

Closed
Tracked by #61
kahest opened this issue Mar 6, 2024 · 0 comments · Fixed by #3722
Closed
Tracked by #61

Add sdk version to user agent string #3713

kahest opened this issue Mar 6, 2024 · 0 comments · Fixed by #3722
Assignees
@kahest
Labels
Platform: Cocoa

Comments

@kahest
Copy link
Member

kahest commented Mar 6, 2024 •
edited
Loading

Currently, the SDK only sets the SDK name:

sentry-cocoa/Sources/Sentry/SentryNSURLRequest.m

Line 61 in 61a1a2b

[self setValue:SentryMeta.sdkName forHTTPHeaderField:@"User-Agent"];

sentry-cocoa/Sources/Sentry/SentryNSURLRequest.m

Line 96 in 61a1a2b

[self setValue:SentryMeta.sdkName forHTTPHeaderField:@"User-Agent"];

To align with getsentry/team-sdks#61, we want to also send the SDK version using the format
<sdk-name>/<sdk-version>.
@kahest kahest mentioned this issue Mar 6, 2024
Open
@kahest kahest transferred this issue from getsentry/team-sdks Mar 6, 2024
@kahest kahest changed the title sentry-cocoa: add sdk version to user agent string Add sdk version to user agent string Mar 6, 2024
@kahest kahest self-assigned this Mar 7, 2024
@kahest kahest mentioned this issue Mar 8, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kahest kahest

Labels
Platform: Cocoa
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Add SDK version to User-Agent header getsentry/sentry-cocoa
1 participant
@kahest