Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Align/extend User Agents #61

Open
9 of 13 tasks
kahest opened this issue Feb 26, 2024 · 4 comments
Open
9 of 13 tasks

Chore: Align/extend User Agents #61

kahest opened this issue Feb 26, 2024 · 4 comments

Comments

@kahest
Copy link
Member

kahest commented Feb 26, 2024

Description

Currently, some SDKs (e.g. sentry-cocoa) don't set a user agent or just set the SDK name as user agent.
In an effort to make troubleshooting of issues more viable if only the http request headers are available (e.g. looking into LB issues), we want to add more information to the user agent:

  • SDK name + version
  • OS name + version

Define base and optional/additional format

Ensure SDKs use base format

  1. Platform: Cocoa
    kahest
  2. Platform: Android Platform: Java
  3. SDK parity

(Optional) Adopt optional/additional format in SDKs

  1. Platform: Dart

Why should we be doing this?

To make troubleshooting of issues more viable if only the http request headers are available, e.g. in incidents like INC-648

Why now?

The earlier we add at least the basic info (SDK name+version), the higher the likelihood that we have useful information available during the next incident.

RFC

No response

Slack-Channel

#inc-648

Notion Document(s)

INC-648 doc

Stakeholder(s)

INC-648, SRE

Team(s)

Mobile
Web Backend
Web Frontend (?)

@kahest
Copy link
Member Author

kahest commented Feb 28, 2024

We'll align across SDK teams what the User Agent should look like

@kahest kahest changed the title Project: Make User Agent useful Project: Align/extend User Agents Mar 6, 2024
@kahest
Copy link
Member Author

kahest commented Mar 6, 2024

  1. phase: all SDKs send <sdk-name>/<sdk-version>
    • most SDKs already use that format
    • some don’t set anything, some just set <sdk-name>
    • didn’t find an SDK using a different format
    • added tasks to align Mobile+adjacent SDKs, feel free to check your (Web) SDKs as well
  2. phase: align on (optional) additional OS/runtime info
    • don’t need an RFC (?)
    • goal: provide a guideline on how to add that info
    • e.g. something like <sdk-name>/<sdk-version> (<device-name> <device-model>; <os-name> <os-version>; <runtime-name> <runtime-version>)
    • SDKs can implement this on case-by-case basis

@kahest
Copy link
Member Author

kahest commented Apr 17, 2024

somewhat related initiative on Ingest team: https://github.com/getsentry/team-ingest/issues/276

@stephanie-anderson stephanie-anderson added this to the [3] Implementation milestone Jul 4, 2024
@stephanie-anderson stephanie-anderson changed the title Project: Align/extend User Agents Chore: Align/extend User Agents Jul 4, 2024
@stephanie-anderson stephanie-anderson modified the milestones: [3] Implementation, [1] Discovery, Protocol Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

4 participants