feat(hybrid-sdks): Add captureScreenshots to PrivateSDKOnly #2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0032a5d | 1267.35 ms | 1282.34 ms | 14.99 ms |
| d73ebd0 | 1200.83 ms | 1236.10 ms | 35.27 ms |
| db5f62a | 1234.47 ms | 1257.80 ms | 23.33 ms |
| f444dc4 | 1237.39 ms | 1255.42 ms | 18.03 ms |
| e2f1150 | 1220.39 ms | 1249.94 ms | 29.55 ms |
| e2a3f3e | 1224.06 ms | 1248.20 ms | 24.14 ms |
| 347a8e9 | 1243.50 ms | 1265.90 ms | 22.40 ms |
| 202334c | 1265.41 ms | 1277.34 ms | 11.93 ms |
| 58f558d | 1216.15 ms | 1246.22 ms | 30.07 ms |
| ef8b0ce | 1212.34 ms | 1249.64 ms | 37.30 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0032a5d | 20.75 KiB | 369.27 KiB | 348.52 KiB |
| d73ebd0 | 20.50 KiB | 365.18 KiB | 344.68 KiB |
| db5f62a | 20.51 KiB | 333.16 KiB | 312.65 KiB |
| f444dc4 | 20.75 KiB | 367.00 KiB | 346.24 KiB |
| e2f1150 | 20.51 KiB | 333.10 KiB | 312.59 KiB |
| e2a3f3e | 20.75 KiB | 368.01 KiB | 347.26 KiB |
| 347a8e9 | 20.51 KiB | 333.16 KiB | 312.65 KiB |
| 202334c | 20.51 KiB | 331.79 KiB | 311.28 KiB |
| 58f558d | 20.50 KiB | 338.99 KiB | 318.49 KiB |
| ef8b0ce | 20.50 KiB | 337.71 KiB | 317.20 KiB |
|
Just these tests fail. https://github.com/getsentry/sentry-cocoa/actions/runs/3463872711/jobs/5784750772 Otherwise, it's done. |
krystofwoldrich
requested review from
philipphofmann,
brustolin and
armcknight
as code owners
brustolin
approved these changes
Nov 15, 2022
krystofwoldrich
changed the title
|
kevinrenskers
added a commit
that referenced
this pull request
Nov 16, 2022
…ents * master: Fix: Set the correct OOM event timestamp (#2394) test: Fix SentrySerializationTests.testSerializationFailsWithInvalidJSONObject (#2392) feat(hybrid-sdks): Add captureScreenshots to PrivateSDKOnly (#2384) ci: Increase test timeout for iOS 12 (#2391) test: Disable flaky testCrashReportCount1 (#2389) test: Disable flaky testSerializeWithUnderlyingNSException (#2387)
9 tasks
kevinrenskers
added a commit
that referenced
this pull request
Nov 24, 2022
* master: (56 commits) meta: disable swiftlint file length check in TBDBClient.swift (#2435) Revert "test: shorten some tests (#2422)" (#2427) test: shorten some tests (#2422) test: include Sentry changes in hash keys (#2412) release: 7.31.2 fix: Crash in Client when reading integrations (#2398) test: tooling improvements (#2400) fix: Don't increase session's error count for dropped events (#2374) Update CHANGELOG.md (#2396) release: 7.31.1 Fix: Set the correct OOM event timestamp (#2394) test: Fix SentrySerializationTests.testSerializationFailsWithInvalidJSONObject (#2392) feat(hybrid-sdks): Add captureScreenshots to PrivateSDKOnly (#2384) ci: Increase test timeout for iOS 12 (#2391) test: Disable flaky testCrashReportCount1 (#2389) test: Disable flaky testSerializeWithUnderlyingNSException (#2387) build(deps): bump github/codeql-action from 2.1.31 to 2.1.32 (#2386) build(deps): bump fastlane from 2.210.1 to 2.211.0 (#2385) ref: json serialization error reporting (#2355) release: 7.31.0 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
To avoid duplication code I would like to expose the screenshot function via the PrivateSDKOnly header.
💡 Motivation and Context
💚 How did you test it?
Not yet.
📝 Checklist
🔮 Next steps
#skip-changelog