fix: changelog entries after 8.14.2 #3379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armcknight
changed the title
indragiek
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After releasing 8.14.2, other PRs were merged without first merging in
mainagain, so their stale diffs didn't appear to be adding their changelog entries under 8.14.2 instead of Unreleased, but that's what wound up happening.And also one made it in in between us updating changelog for 8.14.2 and actually merging that release branch back into main:
I still think that craft should not be renaming
Unreleasedto whatever version is being released; instead inserting the section header for the release underneathUnreleased, leaving that unreleased section header always. I think the way git diffs work would avoid some of this issue: getsentry/craft#422#skip-changelog