fix: Clang error for Xcode 15.4 #3958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipphofmann
approved these changes
May 10, 2024
There was a problem hiding this comment.
Thank you @brustolin 💯.
I think we should also update the troubleshooting guide in the docs, as I expect that multiple people could run into this problem once Xcode 15.4 is released.
kahest
approved these changes
May 10, 2024
1 task
threema-matteo
pushed a commit
to threema-ch/sentry-cocoa
that referenced
this pull request
May 21, 2024
The hacky solution introduced in the PR getsentry#3774 is breaking compilation for Xcode 15.4 This solution will keep both Xcode 15 (.3 and .4) working. I believe we can remove the version replacement after a few months after Xcode 15.4 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
The hacky solution introduced in the PR #3774 is breaking compilation for Xcode 15.4
This solution will keep both Xcode 15 (.3 and .4) working.
I believe we can remove the version replacement after a few months after Xcode 15.4 release.
💡 Motivation and Context
closes #3947
💚 How did you test it?
Samples
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.🔮 Next steps