fix: guard against null thread handle for profiler sampling thread #4076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s returned as nil
…handle comes back as null
armcknight
commented
Jun 15, 2024
philipphofmann
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
LGTM, but I think we should still wait for @indragiek before merging this.
indragiek
reviewed
Jun 19, 2024
armcknight
merged commit 6fac4d6
into
indragiek/pthread_mach_thread_np-null
53 of 59 checks passed
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the conversation starting here: #3520 (comment)
#skip-changelog