Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecate options.enableTracing. #4182

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Conversation

brustolin
Copy link
Contributor

Deprecating options.enableTracing in order to completely remove it in the next major.

Closes #4177

Copy link

github-actions bot commented Jul 19, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1219.12 ms 1231.48 ms 12.36 ms
Size 21.58 KiB 683.64 KiB 662.06 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
699d76f 1238.08 ms 1257.67 ms 19.59 ms
46267d8 1229.80 ms 1244.16 ms 14.37 ms
c0b4b71 1218.16 ms 1251.28 ms 33.12 ms
455619d 1231.40 ms 1237.70 ms 6.30 ms
103d817 1211.55 ms 1213.35 ms 1.80 ms
7bbb7c3 1232.40 ms 1249.78 ms 17.38 ms
1ac58a6 1232.07 ms 1254.69 ms 22.63 ms
e998fd0 1241.49 ms 1262.63 ms 21.14 ms
42ef6ba 1201.67 ms 1214.35 ms 12.67 ms
ef5821b 1253.18 ms 1265.46 ms 12.28 ms

App size

Revision Plain With Sentry Diff
699d76f 21.58 KiB 631.82 KiB 610.24 KiB
46267d8 21.58 KiB 572.21 KiB 550.63 KiB
c0b4b71 20.76 KiB 430.98 KiB 410.22 KiB
455619d 20.76 KiB 432.87 KiB 412.11 KiB
103d817 21.58 KiB 571.91 KiB 550.33 KiB
7bbb7c3 21.58 KiB 418.78 KiB 397.20 KiB
1ac58a6 21.58 KiB 626.07 KiB 604.49 KiB
e998fd0 21.58 KiB 414.59 KiB 393.01 KiB
42ef6ba 21.58 KiB 417.86 KiB 396.28 KiB
ef5821b 21.58 KiB 414.96 KiB 393.37 KiB

Previous results on branch: deprecate/enableTrace

Startup times

Revision Plain With Sentry Diff
0841b08 1227.76 ms 1248.77 ms 21.02 ms

App size

Revision Plain With Sentry Diff
0841b08 21.58 KiB 681.74 KiB 660.16 KiB

@brustolin brustolin merged commit bb71736 into main Jul 24, 2024
42 of 44 checks passed
@brustolin brustolin deleted the deprecate/enableTrace branch July 24, 2024 06:57
Copy link

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Deprecate options.enableTracing ([#4182](https://github.com/getsentry/sentry-cocoa/pull/4182))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 078cd6a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate enableTracing option
3 participants