Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Sentry._Hybrid explicit module #4440

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
564df98
Expose `HybridSDK ` from `Sentry` framework
denrase Oct 15, 2024
e8df557
Merge branch 'main' into feat/hybrid-sdk-private-modulemap
denrase Oct 15, 2024
9de3145
Format code
getsentry-bot Oct 15, 2024
feec600
add cl entry
denrase Oct 15, 2024
60a9606
Merge branch 'feat/hybrid-sdk-private-modulemap' of github.com:getsen…
denrase Oct 15, 2024
68a941d
Merge branch 'main' into feat/hybrid-sdk-private-modulemap
denrase Oct 21, 2024
e22fa14
remove MODULEMAP_PRIVATE_FILE entries
denrase Oct 21, 2024
b60ee61
fix cl
denrase Oct 21, 2024
fe9a30e
format
denrase Oct 21, 2024
cf3d1f3
Merge branch 'main' into feat/hybrid-sdk-private-modulemap
denrase Nov 6, 2024
37ab474
move hybrid headers into header file
denrase Nov 6, 2024
d020bbe
Format code
getsentry-bot Nov 6, 2024
99d5378
update changelog
denrase Nov 6, 2024
a68898f
Merge branch 'feat/hybrid-sdk-private-modulemap' of github.com:getsen…
denrase Nov 6, 2024
dfea6a5
move SentryHybrid to parent folder
denrase Nov 6, 2024
e3fa03a
include PrivateSentrySDKOnly
denrase Nov 6, 2024
ac0cd21
mark _Hybrid as private to other modules
denrase Nov 6, 2024
3900f5a
remove duplicate import
denrase Nov 6, 2024
48c1750
remove private
denrase Nov 6, 2024
7116017
fix SentrySampling header import
denrase Nov 6, 2024
d165c47
private modulemap
denrase Nov 6, 2024
46da4be
fix non-modular header issue
denrase Nov 6, 2024
8e27947
Merge branch 'main' into feat/hybrid-sdk-private-modulemap
denrase Nov 6, 2024
c54f06e
Format code
getsentry-bot Nov 6, 2024
d353fe1
add comment
denrase Nov 6, 2024
a5b1713
fix SentrySessionReplayIntegration import uild issues
denrase Nov 11, 2024
ca22e22
Merge branch 'main' into feat/hybrid-sdk-private-modulemap
denrase Nov 11, 2024
13dcf28
fix cl
denrase Nov 11, 2024
a0870f6
fix import
denrase Nov 11, 2024
1eb2388
set SENTRY_TARGET_REPLAY_SUPPORTED in SentrySessionReplayIntegration-…
denrase Nov 11, 2024
af3bf8f
conditionally import
denrase Nov 11, 2024
acfea44
fix xcode select version
denrase Nov 11, 2024
af3f1c5
Merge branch 'main' into feat/hybrid-sdk-private-modulemap
denrase Nov 11, 2024
da199c2
fix lint issue
denrase Nov 11, 2024
2d2ad7f
use macos-14 runner in lint (works building locally)
denrase Nov 11, 2024
6db3918
try xcode 16.0
denrase Nov 11, 2024
49d705a
run on xcode 15.0
denrase Nov 11, 2024
6be47ff
no need for .1, as theres a symlink
denrase Nov 11, 2024
51e5c3d
import Sentry._Hybrid in XCFramework sample
denrase Nov 13, 2024
a4bca18
Merge branch 'main' into feat/hybrid-sdk-private-modulemap
denrase Nov 13, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,15 @@ jobs:

xcode-analyze:
name: Xcode Analyze
runs-on: macos-13
runs-on: macos-14
steps:
- uses: actions/checkout@v4
- run: ./scripts/ci-select-xcode.sh
- run: ./scripts/ci-select-xcode.sh 15.0
- run: make analyze

lint-podspec:
name: pod lint ${{ matrix.podspec}} ${{ matrix.library_type }} ${{ matrix.platform}}
runs-on: macos-13
runs-on: macos-14
strategy:
fail-fast: false
matrix:
Expand All @@ -58,19 +58,19 @@ jobs:

steps:
- uses: actions/checkout@v4
- run: ./scripts/ci-select-xcode.sh
- run: ./scripts/ci-select-xcode.sh 15.0
# We need to update the spec-repo, because it can happen that it is not up to date and then the lint fails.
- run: pod repo update
- name: Validate Podspec
run: ./scripts/pod-lib-lint.sh ${{ matrix.platform }} ${{ matrix.podspec}} ${{ matrix.library_type}}

lint-hybrid-sdk-podspec:
name: pod lint Sentry/HybridSDK
runs-on: macos-13
runs-on: macos-14

steps:
- uses: actions/checkout@v4
- run: ./scripts/ci-select-xcode.sh
- run: ./scripts/ci-select-xcode.sh 15.0
- run: pod repo update
- name: Validate HybridPod Podspec
run: pod lib lint ./Tests/HybridSDKTest/HybridPod.podspec --allow-warnings --verbose --platforms=ios "--include-podspecs={Sentry.podspec}"
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@
- Concurrency crash with Swift 6 (#4512)
- Make `Scope.span` fully thread safe (#4519)

### Improvements

- Expose `Sentry._Hybrid` explicit module (#4440)

## 8.40.1

### Fixes
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import Sentry
import Sentry._Hybrid
import UIKit

@main
Expand All @@ -12,6 +13,9 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
options.sessionTrackingIntervalMillis = 5_000
}

// Available through Sentry._Hybrid
print(PrivateSentrySDKOnly.getSdkName())

return true
}

Expand Down
2 changes: 0 additions & 2 deletions Samples/iOS-Swift/iOS-Swift.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,6 @@
D8269A42274C095F00BD5BD5 /* Base */ = {isa = PBXFileReference; lastKnownFileType = file.storyboard; name = Base; path = Base.lproj/Main.storyboard; sourceTree = "<group>"; };
D8269A49274C096000BD5BD5 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
D8269A5C274C108100BD5BD5 /* iOS13-Swift.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.plist.entitlements; path = "iOS13-Swift.entitlements"; sourceTree = "<group>"; };
D82915932C889F1800A6CDD4 /* SentryCocoaPrivate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SentryCocoaPrivate.h; sourceTree = "<group>"; };
D83A30DF279F1F5C00372D0A /* fatal-error-binary-images-message2.json */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.json; name = "fatal-error-binary-images-message2.json"; path = "../../../Tests/Resources/fatal-error-binary-images-message2.json"; sourceTree = "<group>"; };
D840D520273A07F400CDF142 /* iOS-SwiftClip.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = "iOS-SwiftClip.app"; sourceTree = BUILT_PRODUCTS_DIR; };
D840D522273A07F400CDF142 /* AppDelegate.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AppDelegate.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -624,7 +623,6 @@
D8F01DF02A1377D0008F4996 /* SentryExposure.h */,
D8832B192AF4FE2000C522B0 /* SentryUIApplication.h */,
629EC8AC2B0B537400858855 /* TriggerAppHang.swift */,
D82915932C889F1800A6CDD4 /* SentryCocoaPrivate.h */,
84BA71E32C8BBBEC0045B828 /* DSNDisplayViewController.swift */,
84BA71F02C8BC55A0045B828 /* Toasts.swift */,
);
Expand Down
32 changes: 0 additions & 32 deletions Samples/iOS-Swift/iOS-Swift/Tools/SentryCocoaPrivate.h

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#import "SentryBenchmarking.h"
#import "SentryCocoaPrivate.h"
#import "SentryExposure.h"
#import "SentryUIApplication.h"
#import <Sentry/PrivateSentrySDKOnly.h>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#import "SentryBenchmarking.h"
#import "SentryCocoaPrivate.h"
#import "SentryUIApplication.h"
#import <Sentry/PrivateSentrySDKOnly.h>
#import <Sentry/SentrySDK+Private.h>
Loading
Loading