Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Build visionOS project with static Sentry SDK #4462

Merged
merged 10 commits into from
Oct 24, 2024

Conversation

brustolin
Copy link
Contributor

📜 Description

We need to enable Swift interoperability with c++ for our visionOS SDK, in order to make the static SDK work with visionOS projects

💡 Motivation and Context

Close #3809

💚 How did you test it?

External sample

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Copy link

github-actions bot commented Oct 21, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.76 ms 1262.33 ms 36.57 ms
Size 21.90 KiB 708.96 KiB 687.06 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
51ffd8c 1194.60 ms 1215.70 ms 21.10 ms
0559a8f 1236.90 ms 1253.46 ms 16.56 ms
75f7fc8 1239.31 ms 1266.12 ms 26.82 ms
5c115c5 1249.04 ms 1260.36 ms 11.32 ms
6ae86f6 1231.90 ms 1255.90 ms 24.00 ms
7419285 1209.53 ms 1244.72 ms 35.19 ms
76c2ac7 1226.84 ms 1247.22 ms 20.39 ms
dc8ab43 1220.39 ms 1238.04 ms 17.65 ms
e758449 1243.41 ms 1246.71 ms 3.31 ms
04c0c68 1223.22 ms 1251.24 ms 28.02 ms

App size

Revision Plain With Sentry Diff
51ffd8c 21.58 KiB 418.70 KiB 397.11 KiB
0559a8f 21.58 KiB 419.81 KiB 398.22 KiB
75f7fc8 21.58 KiB 704.23 KiB 682.65 KiB
5c115c5 22.85 KiB 411.72 KiB 388.87 KiB
6ae86f6 21.58 KiB 625.82 KiB 604.23 KiB
7419285 20.76 KiB 432.99 KiB 412.22 KiB
76c2ac7 21.58 KiB 695.48 KiB 673.90 KiB
dc8ab43 21.58 KiB 697.83 KiB 676.25 KiB
e758449 22.85 KiB 407.62 KiB 384.77 KiB
04c0c68 22.85 KiB 414.09 KiB 391.24 KiB

Previous results on branch: fix/vision-os-compilation

Startup times

Revision Plain With Sentry Diff
36816c8 1222.57 ms 1246.35 ms 23.78 ms
ea630f6 1228.64 ms 1246.92 ms 18.28 ms

App size

Revision Plain With Sentry Diff
36816c8 21.90 KiB 708.45 KiB 686.55 KiB
ea630f6 21.90 KiB 708.74 KiB 686.84 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly questions to understand this change better.

Sources/Sentry/SentrySDK.m Outdated Show resolved Hide resolved
Sources/Configuration/SDK.xcconfig Show resolved Hide resolved
Sources/Sentry/SentryLevelHelper.m Show resolved Hide resolved
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sources/Swift/Tools/SentryLog.swift Show resolved Hide resolved
develop-docs/DECISIONS.md Show resolved Hide resolved
@brustolin brustolin merged commit 4569cc9 into main Oct 24, 2024
@brustolin brustolin deleted the fix/vision-os-compilation branch October 24, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

visionOS app fails to build with latest Sentry version, previously succeeded
3 participants