Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically get username and full user name #4674

Merged

Conversation

armcknight
Copy link
Member

Found better ways to automatically grab a username and full name from the user's machine using standard Foundation APIs to inject into the SDK.

#skip-changelog

Copy link

github-actions bot commented Jan 3, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.35 ms 1251.86 ms 24.51 ms
Size 22.31 KiB 765.77 KiB 743.46 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9cc7e7c 1231.84 ms 1245.24 ms 13.41 ms
8e76be4 1272.67 ms 1286.38 ms 13.71 ms
2401cbd 1219.49 ms 1250.14 ms 30.65 ms
e8b14db 1193.58 ms 1225.56 ms 31.98 ms
5d6ce0e 1227.57 ms 1241.08 ms 13.51 ms
d8cc6ae 1228.13 ms 1253.86 ms 25.73 ms
ec879f7 1304.84 ms 1337.04 ms 32.20 ms
c677654 1228.02 ms 1248.65 ms 20.63 ms
7bb0873 1193.70 ms 1222.74 ms 29.04 ms
038edae 1223.35 ms 1246.78 ms 23.43 ms

App size

Revision Plain With Sentry Diff
9cc7e7c 22.84 KiB 403.14 KiB 380.29 KiB
8e76be4 20.76 KiB 427.66 KiB 406.89 KiB
2401cbd 22.85 KiB 408.85 KiB 386.00 KiB
e8b14db 20.76 KiB 401.60 KiB 380.84 KiB
5d6ce0e 22.85 KiB 405.38 KiB 382.53 KiB
d8cc6ae 21.58 KiB 699.25 KiB 677.67 KiB
ec879f7 21.58 KiB 669.68 KiB 648.10 KiB
c677654 22.30 KiB 748.66 KiB 726.36 KiB
7bb0873 22.85 KiB 407.09 KiB 384.24 KiB
038edae 21.58 KiB 678.19 KiB 656.61 KiB

Previous results on branch: armcknight/test/users

Startup times

Revision Plain With Sentry Diff
fb365b7 1240.33 ms 1261.59 ms 21.26 ms

App size

Revision Plain With Sentry Diff
fb365b7 22.31 KiB 765.77 KiB 743.46 KiB

@armcknight armcknight enabled auto-merge (squash) January 6, 2025 23:22
@armcknight armcknight force-pushed the armcknight/test/users branch from 24969e6 to fcc140a Compare January 8, 2025 06:23
@armcknight armcknight changed the base branch from main to armckngiht/ref/app-delegate-sdk-config January 8, 2025 06:24
@armcknight armcknight merged commit 5126088 into armckngiht/ref/app-delegate-sdk-config Jan 8, 2025
44 of 45 checks passed
@armcknight armcknight deleted the armcknight/test/users branch January 8, 2025 06:24
@armcknight
Copy link
Member Author

I don't know why auto-merge just triggered with no approvals ¯_(ツ)_/¯ i changed the base and then it just happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants