Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feedback): hooks #4675

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

armcknight
Copy link
Member

Implement the various hooks that can be set in the form config.

for #4271; #skip-changelog

Copy link

github-actions bot commented Jan 3, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c46d0c2

@armcknight armcknight force-pushed the armcknight/feat(feedback)/hooks branch from 3b9f556 to 8870c6a Compare January 3, 2025 21:45
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 90.549%. Comparing base (79239ff) to head (c46d0c2).

Files with missing lines Patch % Lines
...ift/Integrations/UserFeedback/SentryFeedback.swift 0.000% 15 Missing ⚠️
...grations/UserFeedback/SentryUserFeedbackForm.swift 0.000% 8 Missing ⚠️
...ations/UserFeedback/SentryUserFeedbackWidget.swift 0.000% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4675       +/-   ##
=============================================
- Coverage   90.588%   90.549%   -0.040%     
=============================================
  Files          623       623               
  Lines        71285     71316       +31     
  Branches     25359     25395       +36     
=============================================
  Hits         64576     64576               
- Misses        6617      6648       +31     
  Partials        92        92               
Files with missing lines Coverage Δ
...onfiguration/SentryUserFeedbackConfiguration.swift 0.000% <ø> (ø)
...ations/UserFeedback/SentryUserFeedbackWidget.swift 0.000% <0.000%> (ø)
...grations/UserFeedback/SentryUserFeedbackForm.swift 0.000% <0.000%> (ø)
...ift/Integrations/UserFeedback/SentryFeedback.swift 67.346% <0.000%> (-29.712%) ⬇️

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79239ff...c46d0c2. Read the comment docs.

Copy link

github-actions bot commented Jan 3, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1242.06 ms 1257.94 ms 15.88 ms
Size 22.31 KiB 767.29 KiB 744.98 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9cc7e7c 1231.84 ms 1245.24 ms 13.41 ms
8e76be4 1272.67 ms 1286.38 ms 13.71 ms
2401cbd 1219.49 ms 1250.14 ms 30.65 ms
e8b14db 1193.58 ms 1225.56 ms 31.98 ms
5d6ce0e 1227.57 ms 1241.08 ms 13.51 ms
d8cc6ae 1228.13 ms 1253.86 ms 25.73 ms
ec879f7 1304.84 ms 1337.04 ms 32.20 ms
c677654 1228.02 ms 1248.65 ms 20.63 ms
7bb0873 1193.70 ms 1222.74 ms 29.04 ms
038edae 1223.35 ms 1246.78 ms 23.43 ms

App size

Revision Plain With Sentry Diff
9cc7e7c 22.84 KiB 403.14 KiB 380.29 KiB
8e76be4 20.76 KiB 427.66 KiB 406.89 KiB
2401cbd 22.85 KiB 408.85 KiB 386.00 KiB
e8b14db 20.76 KiB 401.60 KiB 380.84 KiB
5d6ce0e 22.85 KiB 405.38 KiB 382.53 KiB
d8cc6ae 21.58 KiB 699.25 KiB 677.67 KiB
ec879f7 21.58 KiB 669.68 KiB 648.10 KiB
c677654 22.30 KiB 748.66 KiB 726.36 KiB
7bb0873 22.85 KiB 407.09 KiB 384.24 KiB
038edae 21.58 KiB 678.19 KiB 656.61 KiB

Previous results on branch: armcknight/feat(feedback)/hooks

Startup times

Revision Plain With Sentry Diff
09b27a1 1235.10 ms 1260.96 ms 25.86 ms

App size

Revision Plain With Sentry Diff
09b27a1 22.31 KiB 767.23 KiB 744.92 KiB

@armcknight
Copy link
Member Author

Need to investigate why the UI tests are now failing with the new assertions while they pass locally.

@armcknight armcknight marked this pull request as draft January 6, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant