-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feedback): hooks #4675
base: main
Are you sure you want to change the base?
feat(feedback): hooks #4675
Conversation
|
3b9f556
to
8870c6a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4675 +/- ##
=============================================
- Coverage 90.588% 90.549% -0.040%
=============================================
Files 623 623
Lines 71285 71316 +31
Branches 25359 25395 +36
=============================================
Hits 64576 64576
- Misses 6617 6648 +31
Partials 92 92
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9cc7e7c | 1231.84 ms | 1245.24 ms | 13.41 ms |
8e76be4 | 1272.67 ms | 1286.38 ms | 13.71 ms |
2401cbd | 1219.49 ms | 1250.14 ms | 30.65 ms |
e8b14db | 1193.58 ms | 1225.56 ms | 31.98 ms |
5d6ce0e | 1227.57 ms | 1241.08 ms | 13.51 ms |
d8cc6ae | 1228.13 ms | 1253.86 ms | 25.73 ms |
ec879f7 | 1304.84 ms | 1337.04 ms | 32.20 ms |
c677654 | 1228.02 ms | 1248.65 ms | 20.63 ms |
7bb0873 | 1193.70 ms | 1222.74 ms | 29.04 ms |
038edae | 1223.35 ms | 1246.78 ms | 23.43 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9cc7e7c | 22.84 KiB | 403.14 KiB | 380.29 KiB |
8e76be4 | 20.76 KiB | 427.66 KiB | 406.89 KiB |
2401cbd | 22.85 KiB | 408.85 KiB | 386.00 KiB |
e8b14db | 20.76 KiB | 401.60 KiB | 380.84 KiB |
5d6ce0e | 22.85 KiB | 405.38 KiB | 382.53 KiB |
d8cc6ae | 21.58 KiB | 699.25 KiB | 677.67 KiB |
ec879f7 | 21.58 KiB | 669.68 KiB | 648.10 KiB |
c677654 | 22.30 KiB | 748.66 KiB | 726.36 KiB |
7bb0873 | 22.85 KiB | 407.09 KiB | 384.24 KiB |
038edae | 21.58 KiB | 678.19 KiB | 656.61 KiB |
Need to investigate why the UI tests are now failing with the new assertions while they pass locally. |
Implement the various hooks that can be set in the form config.
for #4271; #skip-changelog