better docs

getsentry · philprime · Jan 31, 2025 · Jan 27, 2025 · Jan 27, 2025 · Jan 28, 2025
commit 4a7545b51065e7d79ece9a223ebebc0b4deca3cf
@@ -48,12 +48,12 @@ NS_SWIFT_NAME(TraceContext)
 @property (nullable, nonatomic, readonly) NSString *userSegment;
 
 /**
- * Sample rate used for this trace.
+ * Serialized sample rate used for this trace.
  */
 @property (nullable, nonatomic, readonly) NSString *sampleRate;
 
 /**
- * Random value used to determine if the trace is sampled.
+ * Serialized random value used to determine if the trace is sampled.
  */
 @property (nullable, nonatomic, readonly) NSString *sampleRand;
 

diff --git a/Sources/Sentry/SentrySampling.m b/Sources/Sentry/SentrySampling.m
    if (context.transactionContext.parentSampled != kSentrySampleDecisionUndecided) {
        return
            [[SentrySamplerDecision alloc] initWithDecision:context.transactionContext.parentSampled
                                              forSampleRate:context.transactionContext.sampleRate
                                             withSampleRand:context.transactionContext.sampleRand];
    }

    return _sentry_calcSampleFromNumericalRate(options.tracesSampleRate);
diff --git a/Tests/SentryTests/Transaction/SentryTracerTests.swift b/Tests/SentryTests/Transaction/SentryTracerTests.swift
        func startTracer() throws {
            let sut = fixture.getSut()
            
            timer = try XCTUnwrap(Dynamic(sut).deadlineTimer.asObject as? Timer)
            weakSut = sut
            
            // The TestHub keeps a reference to the tracer in capturedEventsWithScopes.
	if (context.transactionContext.parentSampled != kSentrySampleDecisionUndecided) {
	return
	[[SentrySamplerDecision alloc] initWithDecision:context.transactionContext.parentSampled
	forSampleRate:context.transactionContext.sampleRate
	withSampleRand:context.transactionContext.sampleRand];
Check warning on line 82 in Sources/Sentry/SentrySampling.m Codecov / codecov/patch Sources/Sentry/SentrySampling.m#L81-L82 `Added lines #L81 - L82 were not covered by tests`
	}

	return _sentry_calcSampleFromNumericalRate(options.tracesSampleRate);
	func startTracer() throws {
	let sut = fixture.getSut()

	timer = try XCTUnwrap(Dynamic(sut).deadlineTimer.asObject as? Timer)
Check failure on line 306 in Tests/SentryTests/Transaction/SentryTracerTests.swift GitHub Actions / Unit iOS - Xcode 15.4 - OS 17.2 Sentry `testCancelDeadlineTimer_TracerDeallocated, XCTUnwrap failed: expected non-nil value of type "NSTimer"`
	weakSut = sut

	// The TestHub keeps a reference to the tracer in capturedEventsWithScopes.